Skip to content
This repository was archived by the owner on May 28, 2019. It is now read-only.

Add b2g shim for mozPaymentProvider (bug 1112226)#180

Merged
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:b2g-shim
Dec 17, 2014
Merged

Add b2g shim for mozPaymentProvider (bug 1112226)#180
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:b2g-shim

Conversation

@kumar303
Copy link
Copy Markdown
Contributor

@muffinresearch r?

If we don't clean this up now, we never will :)

@kumar303
Copy link
Copy Markdown
Contributor Author

I decided that NO_PAY_SUCCESS_FUNC is really not very useful and I don't think we should keep it around. If paymentSuccess is missing on b2g then it will fail on the missing window.opener and that will be enough for us to figure out what's happening.

Comment thread tests/helpers.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@muffinresearch
Copy link
Copy Markdown
Contributor

This is great - thanks for doing this. r+

kumar303 added a commit that referenced this pull request Dec 17, 2014
Add b2g shim for mozPaymentProvider (bug 1112226)
@kumar303 kumar303 merged commit 1c1368c into mozilla:master Dec 17, 2014
@kumar303 kumar303 deleted the b2g-shim branch December 17, 2014 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants