Skip to content

Conversation

@gene1wood
Copy link
Collaborator

@gene1wood gene1wood commented May 15, 2023

This adds the TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 / DHE-RSA-CHACHA20-POLY1305 cipher to the end of the intermediate cipher lists for openssl and iana.

You can see the specific cipher list change in b2a5a06

See related PR mozilla/server-side-tls#291

Fixes mozilla/server-side-tls#285

gene1wood added 2 commits May 15, 2023 15:31
…configuration

This adds the `TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256` / `DHE-RSA-CHACHA20-POLY1305` cipher to the end of the intermediate cipher lists for openssl and iana.

Fixes mozilla/server-side-tls#285
gene1wood added a commit to gene1wood/server-side-tls that referenced this pull request May 15, 2023
…configuration

This adds the `TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256` / `DHE-RSA-CHACHA20-POLY1305` cipher to the end of the intermediate cipher list.

See the related PR mozilla/ssl-config-generator#204

Fixes mozilla#285
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this out and there is a versioned symlink in the src/static/guidelines directory that probably needs to be updated as well. Approval is conditional on fixing that up.

lrwxrwxrwx 1 martin martin     8 May 16 11:31 latest.json -> 5.6.json

That's all I can see (you could update the changelog to point to this commit, but then that might not work out once this merges in).

@gene1wood
Copy link
Collaborator Author

I checked this out and there is a versioned symlink in the src/static/guidelines directory that probably needs to be updated as well. Approval is conditional on fixing that up.

Good catch, thanks for pointing that out. Fixed in f842855

That's all I can see (you could update the changelog to point to this commit, but then that might not work out once this merges in).

Indeed, since we don't have versioned tags or releases in this repo (I figured that I didn't want to start versioning the entire repo just for the guideline) I figured I'd go in after and update the changelog to point to the right commit.

Long term, we may want to version the guideline outside of this repo so it can have tagged version, distinct from the version of the ssl-config-generator.

@gene1wood gene1wood merged commit c213252 into mozilla:master May 16, 2023
@gene1wood gene1wood deleted the add_TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 branch May 16, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256

2 participants