Conversation
added 11 commits
January 22, 2020 11:52
Closed
calixteman
approved these changes
Jan 22, 2020
| # Check version of remote daemon | ||
| self.client = really_old_docker.from_env(version=TASKCLUSTER_DIND_API_VERSION) | ||
| version = self.client.version() | ||
| assert ( |
Collaborator
There was a problem hiding this comment.
why do you check version here ? Can the version be different from the one passed as argument ?
Contributor
Author
There was a problem hiding this comment.
In the context of Taskcluster, the version is fixed to a really old one. If it changes, the client i'm using will fail horribly, so we want to know well before doing any damage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.