Skip to content

Remove an useless part from a download-artifact's option #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
May 15, 2020
Merged

Remove an useless part from a download-artifact's option #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion taskboot/artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

import logging
import pathlib

from taskboot.config import Configuration
from taskboot.utils import load_named_artifacts
Expand All @@ -20,9 +21,15 @@ def retrieve_artifacts(target, args):
# Load config from file/secret
config = Configuration(args)

# Replace the path to the artifact with the load_named_version format
# worker-type:artifact path
artifacts = [
str(pathlib.Path(artifact).stem) + ":" + artifact for artifact in args.artifacts
]

# Load dependencies artifacts
for _, artifact_name, artifact_path in load_named_artifacts(
config, args.task_id, args.artifacts, args.output_path
config, args.task_id, artifacts, args.output_path
):
logger.info(f"{artifact_name} has been downloaded to {artifact_path}")

Expand Down
2 changes: 1 addition & 1 deletion taskboot/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def main():
"--artifacts",
nargs="+",
type=str,
help="the mapping of worker-type:artifact-path to download",
help="Paths to the artifacts to download on the task",
)
download_artifacts.set_defaults(func=retrieve_artifacts)

Expand Down