Skip to content

decommission desktop_active_dau#652

Merged
relud merged 7 commits intomasterfrom
desktop-active-dau
Nov 13, 2019
Merged

decommission desktop_active_dau#652
relud merged 7 commits intomasterfrom
desktop-active-dau

Conversation

@relud
Copy link
Copy Markdown
Contributor

@relud relud commented Oct 23, 2019

this is actively used by one query https://sql.telemetry.mozilla.org/queries/52720/source which needs to be updated to pick up the changes at https://github.com/mozilla/stmo_core_product_metrics/pull/21

@akkomar
Copy link
Copy Markdown
Member

akkomar commented Oct 23, 2019

this is actively used by one query https://sql.telemetry.mozilla.org/queries/52045/source#138916

You mean this one: https://sql.telemetry.mozilla.org/queries/52720/source ? @mreid-moz - do you need this query?

@relud
Copy link
Copy Markdown
Contributor Author

relud commented Oct 23, 2019

oops, my bad. yes, that one.

@akkomar
Copy link
Copy Markdown
Member

akkomar commented Oct 25, 2019

this is actively used by one query https://sql.telemetry.mozilla.org/queries/52045/source#138916

You mean this one: https://sql.telemetry.mozilla.org/queries/52720/source ? @mreid-moz - do you need this query?

This query is used in the dashboard linked from MDC. @mreid-moz emailed MDC team about this today.

@mreid-moz
Copy link
Copy Markdown
Contributor

I think it should be safe to switch 52720 to use the more modern "exact mau" tables for this query, though I would prefer to drop it altogether if I can verify that they're no longer needed in MDC.

@mreid-moz
Copy link
Copy Markdown
Contributor

I checked, and this query is linked to from MDC, so we should update it to used the exact_* tables.

@relud
Copy link
Copy Markdown
Contributor Author

relud commented Oct 31, 2019

I double-checked the results of the query before and after using exact active mau, and the graphs look almost identical, exact is just smoother, so i went ahead and updated the query. this PR should now be safe to merge.

@relud relud merged commit e4806cd into master Nov 13, 2019
@relud relud deleted the desktop-active-dau branch November 13, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants