This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Fix spark mode on experiment jobs#274
Merged
acmiyaguchi merged 1 commit intomozilla:masterfrom Aug 2, 2017
Merged
Conversation
be80856 to
55f7a3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 66.12% 66.11% -0.01%
==========================================
Files 37 37
Lines 3371 3373 +2
Branches 80 83 +3
==========================================
+ Hits 2229 2230 +1
- Misses 1142 1143 +1
Continue to review full report at Codecov.
|
acmiyaguchi
approved these changes
Aug 2, 2017
Contributor
acmiyaguchi
left a comment
There was a problem hiding this comment.
This makes sense, now I understand why the job for a single experiment finished in the same amount of time on 1 machine and 10 machines.
Contributor
|
I'm going to rerun the experiments job for 20170724 on airflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welp. I'm gonna guess at least a few of the problems with the experiment jobs are due to hard-coding local spark mode.