Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Fix spark mode on experiment jobs#274

Merged
acmiyaguchi merged 1 commit intomozilla:masterfrom
sunahsuh:fix-spark-mode
Aug 2, 2017
Merged

Fix spark mode on experiment jobs#274
acmiyaguchi merged 1 commit intomozilla:masterfrom
sunahsuh:fix-spark-mode

Conversation

@sunahsuh
Copy link
Contributor

@sunahsuh sunahsuh commented Aug 2, 2017

Welp. I'm gonna guess at least a few of the problems with the experiment jobs are due to hard-coding local spark mode.

@sunahsuh sunahsuh requested a review from acmiyaguchi August 2, 2017 01:22
@codecov-io
Copy link

Codecov Report

Merging #274 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   66.12%   66.11%   -0.01%     
==========================================
  Files          37       37              
  Lines        3371     3373       +2     
  Branches       80       83       +3     
==========================================
+ Hits         2229     2230       +1     
- Misses       1142     1143       +1
Impacted Files Coverage Δ
...zilla/telemetry/views/ExperimentAnalysisView.scala 44.44% <0%> (+1.89%) ⬆️
...ozilla/telemetry/views/ExperimentSummaryView.scala 19.23% <0%> (-7.19%) ⬇️
...in/scala/com/mozilla/telemetry/utils/package.scala 81.03% <100%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ecef0...55f7a3c. Read the comment docs.

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, now I understand why the job for a single experiment finished in the same amount of time on 1 machine and 10 machines.

@acmiyaguchi
Copy link
Contributor

I'm going to rerun the experiments job for 20170724 on airflow.

@acmiyaguchi acmiyaguchi merged commit 783ea94 into mozilla:master Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants