This repository was archived by the owner on Dec 6, 2019. It is now read-only.
Prod#51
Merged
maurodoglio merged 3 commits intomasterfrom Jun 8, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 68.39% 65.56% -2.84%
==========================================
Files 3 3
Lines 231 241 +10
Branches 12 11 -1
==========================================
Hits 158 158
- Misses 73 83 +10
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some minimal changes needed to build a fat jar for use in the dev/prod environments. I also added some additional command-line parameters for checkpoint management.
We no longer hard-code the spark master address, so it needs to be specified to spark-submit or similar. We could fall back to
local[*]as we do in some telemetry-batch-view jobs, but the only application over there that is usingSparkSession.builder()is simply hard-codingyarnand therefore does not fall back.