feat(gke): Enable Shielded Instances#474
Merged
Merged
Conversation
We are currently getting the default top level configuration to enable shielding in the cluster but it is not enabled at the node pool level. Enabling at the node pool recreates the nodepool so instead I want to allow configuring per nodepool, rolling out a new nodepool, and then draining the old node pool. This also allows us to test with things like GPU or only in non-production for now.
bkochendorfer
requested review from
a team,
ahoneiser,
jasonthomas,
jbuck and
mikaeld
as code owners
Contributor
Release plan
|
jasonthomas
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are currently getting the default top level configuration to enable shielding in the cluster but it is not enabled at the node pool level. Enabling at the node pool recreates the nodepool so instead I want to allow configuring per nodepool, rolling out a new nodepool, and then draining the old node pool.
This also allows us to test with things like GPU or only in non-production for now.
Related Tickets & Documents