This repository was archived by the owner on Jan 17, 2023. It is now read-only.
On add-on first run, open Test Pilot if not already open (closes #1374).#1379
Merged
chuckharmston merged 1 commit intomozilla:masterfrom Sep 19, 2016
chuckharmston:1374-first-run
Merged
On add-on first run, open Test Pilot if not already open (closes #1374).#1379chuckharmston merged 1 commit intomozilla:masterfrom chuckharmston:1374-first-run
chuckharmston merged 1 commit intomozilla:masterfrom
chuckharmston:1374-first-run
Conversation
chuckharmston
changed the title
Author
|
This is ready for review now. |
This was referenced Sep 19, 2016
lmorchard
approved these changes
Sep 19, 2016
Contributor
lmorchard
left a comment
lmorchard
left a comment
There was a problem hiding this comment.
Works for me, looks clean & good
| ToolbarButton.init(settings); | ||
| ExperimentNotifications.init(); | ||
| SharePrompt.init(settings); | ||
| FirstRun.setup(options.reason, settings); |
Contributor
There was a problem hiding this comment.
I can't seem to find the issue now, but I remember you opening one about making this general module pattern cleaner and more like Django. 👍 to this and that in general
| @@ -0,0 +1,137 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
👍 Yay tests, and these pass for me locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review.