This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Audit events sent to GA before public launch#690
Merged
ckprice merged 1 commit intomozilla:masterfrom May 4, 2016
meandavejustice:615-ga-coverage
Merged
Audit events sent to GA before public launch#690ckprice merged 1 commit intomozilla:masterfrom meandavejustice:615-ga-coverage
ckprice merged 1 commit intomozilla:masterfrom
meandavejustice:615-ga-coverage
Conversation
ghost
added
the
| }, | ||
| body: '' | ||
| }).then(() => { | ||
| app.sendToGA('event', { |
There was a problem hiding this comment.
I'm addressing this in my PR as well. Race?
Contributor
Author
There was a problem hiding this comment.
We'll use yours, I'll remove this.
Contributor
Author
|
@ckprice I've addressed your comments, though github didn't collapse them all |
|
|
||
| app.sendToGA('pageview', { | ||
| 'dimension1': this.loggedIn | ||
| 'dimension1': this.loggedIn, |
Contributor
There was a problem hiding this comment.
Can we get this stuff documented in README-METRICS.md - if not as part of this PR, then as part of a follow up in the very near future? Not sure what this dimension stuff is about, so I couldn't really speak to it in a review.
| eventAction: 'button click', | ||
| eventLabel: 'exit survey disabled', | ||
| newTab: true, | ||
| outboundURL: this.ev.target.getAttribute('href') |
Contributor
Author
There was a problem hiding this comment.
oh whoops, fixing now
- refs #615 - added "Active Experiments Running" dimension to ga in `landing-page.js` - added "Number of Active Experiments Running" dimension to ga in `landing-page.js` - remove extra "logout" event handler in header-view.js since we already handle in settings-menu-view.js - added "wiki" event to ga in `settings-menu.js` - added "file issue" event to ga in `settings-menu.js` - added "tour" events to ga in `experiment-tour-dialog-view.js`, 'start', 'cancel', 'next', and 'back' - added "cancel tour" event to ga in `experiment-tour-dialog-view.js` - disable eslint on error logging in `retire-page.js` - update `test/views/landing-page.js` so work with `app.me.installed.length` check
|
r+! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#615 is blocked by #681
landing-page.jslanding-page.jssettings-menu.jssettings-menu.jsexperiment-tour-dialog-view.js, 'start', 'cancel', 'next', and 'back'experiment-tour-dialog-view.jsretire-page.jstest/views/landing-page.jsso work withapp.me.installed.lengthcheck