Skip to content

Bug 1416870 - Always use abbreviated mode for calculating performance test name#2991

Merged
wlach merged 1 commit intomozilla:masterfrom
wlach:1416870-take2
Nov 27, 2017
Merged

Bug 1416870 - Always use abbreviated mode for calculating performance test name#2991
wlach merged 1 commit intomozilla:masterfrom
wlach:1416870-take2

Conversation

@wlach
Copy link
Copy Markdown
Contributor

@wlach wlach commented Nov 27, 2017

This means we no longer display tests as being a "summary" in the
test chooser (you can generally figure that out by noticing that there
is no subtest specified).

… test name

This means we no longer display tests as being a "summary" in the
test chooser (you can generally figure that out by noticing that there
is no subtest specified).
name: signature.name,
lowerIsBetter: signature.lowerIsBetter,
frameworkId: signature.frameworkId,
...signature,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's cool, learned something today ('spread syntax') nice :)

Copy link
Copy Markdown

@rwood-moz rwood-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wlach wlach merged commit 539941c into mozilla:master Nov 27, 2017
@wlach wlach deleted the 1416870-take2 branch November 27, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants