Bug 1328985 - Remove project_specific_id compatibility shim#3030
Merged
Conversation
0da2aaf to
b8a53b7
Compare
edmorley
suggested changes
Dec 15, 2017
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterUniqueTogether( |
Contributor
There was a problem hiding this comment.
Running ./manage.py sqlmigrate model 0020 I got:
BEGIN;
--
-- Alter unique_together for job (0 constraint(s))
--
CREATE INDEX `job_repository_id_20bb4d74` ON `job` (`repository_id`);
ALTER TABLE `job` DROP INDEX `job_repository_id_project_specific_id_7883a5e8_uniq`;
COMMIT;
...this is unfortunately buggy since the CREATE INDEX isn't needed, as the existing 5 other index_together entries that start with repository_id cover that field.
As such this removal will need a RunSQL that just does the ALTER TABLE `job` DROP INDEX `job_repository_id_project_specific_id_7883a5e8_uniq`;.
b1f9bd5 to
1060fce
Compare
edmorley
approved these changes
Dec 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.