Skip to content

Bug 1328985 - Remove project_specific_id compatibility shim#3030

Merged
edmorley merged 1 commit into
mozilla:masterfrom
wlach:1328985
Dec 21, 2017
Merged

Bug 1328985 - Remove project_specific_id compatibility shim#3030
edmorley merged 1 commit into
mozilla:masterfrom
wlach:1328985

Conversation

@wlach
Copy link
Copy Markdown
Contributor

@wlach wlach commented Dec 8, 2017

No description provided.

@wlach wlach force-pushed the 1328985 branch 2 times, most recently from 0da2aaf to b8a53b7 Compare December 8, 2017 22:21
]

operations = [
migrations.AlterUniqueTogether(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running ./manage.py sqlmigrate model 0020 I got:

BEGIN;
--
-- Alter unique_together for job (0 constraint(s))
--
CREATE INDEX `job_repository_id_20bb4d74` ON `job` (`repository_id`);
ALTER TABLE `job` DROP INDEX `job_repository_id_project_specific_id_7883a5e8_uniq`;
COMMIT;

...this is unfortunately buggy since the CREATE INDEX isn't needed, as the existing 5 other index_together entries that start with repository_id cover that field.

As such this removal will need a RunSQL that just does the ALTER TABLE `job` DROP INDEX `job_repository_id_project_specific_id_7883a5e8_uniq`;.

@wlach wlach force-pushed the 1328985 branch 3 times, most recently from b1f9bd5 to 1060fce Compare December 16, 2017 21:48
@edmorley edmorley merged commit 0c81ed8 into mozilla:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants