Bug 1465588 - Remove dead perf dashboard code part2

[sarah-clements]

I missed removing a few things (baseTitle, newTitle, phReleaseBlocker, etc), as mentioned in this pr and detailed in this commit message. Also, I dug deeper into the code and realized that trendtable.html is not being used because the remaining partials that use the ph-component-table component don't have a type attribute of 'trend'.

Tested the compare view locally, including the different filters and it works as expected.

[jmaher]

things look good from my point of view

[edmorley]

Awesome - even less to convert to React! :-)

I spotted one other remaining piece - after the removal here:
https://github.com/mozilla/treeherder/pull/4211/files#diff-5106b6d3e8e25463e577b92199db8864L138

getCounterMap() is never passed the forth argument (blockerCriteria), so that argument and its usage inside the function can be removed too (the reference to isBlocker in that function's comment should also be removed):

treeherder/ui/js/services/perf/compare.js

Line 77 in bcf09f2

getCounterMap: function getDisplayLineData(testName, originalData, newData, blockerCriteria) {

treeherder/ui/js/services/perf/compare.js

Lines 174 to 181 in bcf09f2

	if (blockerCriteria !== undefined &&
	blockerCriteria[testName] !== undefined &&
	cmap.isRegression &&
	cmap.deltaPercentage > blockerCriteria[testName]) {
	cmap.isBlocker = true;
	} else {
	cmap.isBlocker = false;
	}

[edmorley]

Looks great! Between this and #4211 there were 740 lines removed 😃