Bug 1602971 - Improve display of LogViewer icon#5795
Merged
Conversation
camd
force-pushed
the
push-health-log-links
branch
2 times, most recently
from
e73151b to
561c779
Compare
Codecov Report
@@ Coverage Diff @@
## master #5795 +/- ##
==========================================
+ Coverage 40.65% 40.71% +0.05%
==========================================
Files 206 205 -1
Lines 6727 6720 -7
Branches 1439 1435 -4
==========================================
+ Hits 2735 2736 +1
+ Misses 3673 3665 -8
Partials 319 319
Continue to review full report at Codecov.
|
camd
force-pushed
the
push-health-log-links
branch
2 times, most recently
from
e71338f to
efc7032
Compare
armenzg
reviewed
Jan 13, 2020
Collaborator
armenzg
left a comment
armenzg
left a comment
There was a problem hiding this comment.
I will leave this review to Sarah since she's already on it.
camd
force-pushed
the
push-health-log-links
branch
2 times, most recently
from
3d01c56 to
799f672
Compare
camd
force-pushed
the
push-health-log-links
branch
from
799f672 to
cdf5000
Compare
alexandru-io
pushed a commit
to alexandru-io/treeherder
that referenced
this pull request
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: Bug 1602971
Having a ton of links around the jobs can be pretty noisy. So I am following a convention that is used in Perfherder where you provide some links in the tooltip. I ran this by asurkov (bug author) and he seemed to like it ok.
Updated screenshot:
