Bug 1625451 - Provide default for application field#6213
Merged
ionutgoldan merged 1 commit intomozilla:masterfrom Apr 3, 2020
octavian-negru:provide-default-for-application-field-2
Merged
Bug 1625451 - Provide default for application field#6213ionutgoldan merged 1 commit intomozilla:masterfrom octavian-negru:provide-default-for-application-field-2
ionutgoldan merged 1 commit intomozilla:masterfrom
octavian-negru:provide-default-for-application-field-2
Conversation
octavian-negru
added
WIP
db-schema-changes
octavian-negru
changed the title
Contributor
Author
|
Local tests are passing, waiting for Travis to do its job... |
ionutgoldan
reviewed
Apr 1, 2020
ionutgoldan
reviewed
Apr 1, 2020
Contributor
ionutgoldan
left a comment
ionutgoldan
left a comment
There was a problem hiding this comment.
Other than that, I think this looks ok.
Contributor
|
@octavian-negru could you rebase on lastest master? |
Codecov Report
@@ Coverage Diff @@
## master #6213 +/- ##
=======================================
Coverage 75.43% 75.44%
=======================================
Files 464 465 +1
Lines 19233 19237 +4
Branches 1531 1531
=======================================
+ Hits 14509 14513 +4
Misses 4409 4409
Partials 315 315
Continue to review full report at Codecov.
|
Contributor
|
The equivalent raw SQL for the migration script looks like: --
-- Alter field application on performancesignature
--
ALTER TABLE `performance_signature` ALTER COLUMN `application` SET DEFAULT '';
UPDATE `performance_signature` SET `application` = '' WHERE `application` IS NULL;
ALTER TABLE `performance_signature` MODIFY `application` varchar(10) NOT NULL;
ALTER TABLE `performance_signature` ALTER COLUMN `application` DROP DEFAULT; |
ionutgoldan
approved these changes
Apr 2, 2020
Contributor
|
Hi @sarah-clements! Could you take a look over this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back to Bug