Add "browsertime" as a possible performance test in isPerfTest.#6951
Merged
ionutgoldan merged 1 commit intomozilla:masterfrom Jan 11, 2021
Merged
Add "browsertime" as a possible performance test in isPerfTest.#6951ionutgoldan merged 1 commit intomozilla:masterfrom
isPerfTest.#6951ionutgoldan merged 1 commit intomozilla:masterfrom
Conversation
Collaborator
|
@ionutgoldan is a better reviewer for this than I am. |
ionutgoldan
approved these changes
Jan 11, 2021
Contributor
ionutgoldan
left a comment
ionutgoldan
left a comment
There was a problem hiding this comment.
This looks good!
Please rebase on latest master, to fix the broken tests ;)
gmierz
force-pushed
the
isperftest-changes
branch
from
75b13b8 to
0e1bfc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're missing the generate profile button in browsertime tests and it's because they aren't being taken into account in the
isPerfTestfunction. This patch solves issue #6950.