Skip to content

Bug 1185110 - Shorten the IDs for the quick filter field#789

Closed
scriptofer wants to merge 0 commit intomozilla:masterfrom
scriptofer:master
Closed

Bug 1185110 - Shorten the IDs for the quick filter field#789
scriptofer wants to merge 0 commit intomozilla:masterfrom
scriptofer:master

Conversation

@scriptofer
Copy link
Contributor

Replaced log ID with short ID in HTML/CSS and JS.

Review on Reviewable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update this comment also, ie. <!--Quick Filter Field-->

@tojon
Copy link
Contributor

tojon commented Jul 20, 2015

@scriptofer thanks!, this also needs to be added in
https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/main.js#L206

Without it, the keyboard shortcut 'f' doesn't focus the quick filter.

@tojon
Copy link
Contributor

tojon commented Jul 20, 2015

@scriptofer while we're at it, let's change this and its corresponding css from "filter-clear-button" to "quick-filter-clear-btn"

Since we already have a global filter, it would be good to differentiate on the ID here I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is customer facing so we don't need to change this, it can just say what it did prior. Our 'quick' filter changes are generally internal things.

@scriptofer scriptofer closed this Jul 23, 2015
@tojon
Copy link
Contributor

tojon commented Jul 23, 2015

@scriptofer hi, curious why you closed this PR? We generally don't want duplicates (if you were intending on opening another one)?

@scriptofer
Copy link
Contributor Author

I missed something while git squash/rebase and my repo got reset. Thus this pull request gets closed automatically.

I need to create new fork -> new branch -> merge changes from local backup -> sent new pull request.

@tojon
Copy link
Contributor

tojon commented Jul 23, 2015

Ok, keep in mind we want to avoid duplicate PRs in our project going forward. It makes the PR list confusing, and a new commit/branch requires code-reviewing everything again since there is no longer iterative commit/PR history.

You can probably use the backup repo I indicated you set aside, and force re-push master to your remote from that if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants