Bug 1185110 - Shorten the IDs for the quick filter field#789
Bug 1185110 - Shorten the IDs for the quick filter field#789scriptofer wants to merge 0 commit intomozilla:masterfrom scriptofer:master
Conversation
There was a problem hiding this comment.
I think we can update this comment also, ie. <!--Quick Filter Field-->
|
@scriptofer thanks!, this also needs to be added in Without it, the keyboard shortcut 'f' doesn't focus the quick filter. |
|
@scriptofer while we're at it, let's change this and its corresponding css from Since we already have a global filter, it would be good to differentiate on the ID here I think. |
There was a problem hiding this comment.
This is customer facing so we don't need to change this, it can just say what it did prior. Our 'quick' filter changes are generally internal things.
|
@scriptofer hi, curious why you closed this PR? We generally don't want duplicates (if you were intending on opening another one)? |
|
I missed something while git squash/rebase and my repo got reset. Thus this pull request gets closed automatically. I need to create new fork -> new branch -> merge changes from local backup -> sent new pull request. |
|
Ok, keep in mind we want to avoid duplicate PRs in our project going forward. It makes the PR list confusing, and a new commit/branch requires code-reviewing everything again since there is no longer iterative commit/PR history. You can probably use the backup repo I indicated you set aside, and force re-push master to your remote from that if you wish. |
Replaced log ID with short ID in HTML/CSS and JS.