more sample_data updates #8511
Merged
more sample_data updates #8511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaher
force-pushed
the
sample_data
branch
4 times, most recently
from
88c870d to
4498706
Compare
Collaborator
Author
|
attempt to update much of the data we use from sample_data. Also included is a script to generate the data and some documentation updates. Ideally we won't run this very often, but we could run it once a year to keep things more relevant. |
jmaher
force-pushed
the
sample_data
branch
2 times, most recently
from
6f6f407 to
919652e
Compare
jmaher
force-pushed
the
sample_data
branch
3 times, most recently
from
1e44e66 to
0afea9f
Compare
Collaborator
Author
|
ok, down to 7 failed tests- I might be able to resolve a few of these, but will need some help on the perf tests. |
jmaher
force-pushed
the
sample_data
branch
12 times, most recently
from
c4e604a to
5a50d37
Compare
Collaborator
Author
|
this is all good- a few changes to source code and currently 1 part of a test commented out- see the diff for specifics (I left comments) |
jmaher
commented
Mar 5, 2025
jmaher
commented
Mar 5, 2025
jmaher
commented
Mar 5, 2025
jmaher
commented
Mar 5, 2025
jmaher
force-pushed
the
sample_data
branch
2 times, most recently
from
42e957a to
fc81f4b
Compare
Collaborator
Author
|
@Archaeopteryx any chance this can get in this week or next week; Mostly I don't want to deal with any bitrot. |
Archaeopteryx
requested changes
Apr 10, 2025
jmaher
force-pushed
the
sample_data
branch
3 times, most recently
from
3d90dd2 to
bdab829
Compare
Archaeopteryx
approved these changes
Apr 17, 2025
| blob["runMachine"]["name"] = task["machine_name"] | ||
| blob["buildMachine"]["name"] = task["machine_name"] | ||
|
|
||
| pst_tz = pytz.timezone("US/Pacific") |
Collaborator
There was a problem hiding this comment.
Okay. Please create a follow-up bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.