Pcf 634 update is_new_better logic #9075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misspran
requested review from
beatrice-acasandrei and
esanuandra
as code owners
misspran
force-pushed
the
PCF-634-update-is_new_better-logic
branch
from
9c9389e to
a829e16
Compare
gmierz
requested changes
Nov 18, 2025
Collaborator
gmierz
left a comment
gmierz
left a comment
There was a problem hiding this comment.
Overall, it looks like there's a lot of things that have already been calculated by the time we call is_new_better so we shouldn't have a need to recalculate them again.
misspran
force-pushed
the
PCF-634-update-is_new_better-logic
branch
from
ee71484 to
110a2ed
Compare
misspran
force-pushed
the
PCF-634-update-is_new_better-logic
branch
from
110a2ed to
a7215c3
Compare
gmierz
requested changes
Nov 19, 2025
Collaborator
gmierz
left a comment
gmierz
left a comment
There was a problem hiding this comment.
Looks much better thanks for the fixes! Just some minor things left to fix below. You can ignore comments with nit: if you want.
misspran
force-pushed
the
PCF-634-update-is_new_better-logic
branch
from
f3e0d3a to
69b1638
Compare
gmierz
reviewed
Nov 19, 2025
gmierz
approved these changes
Nov 20, 2025
Collaborator
gmierz
left a comment
gmierz
left a comment
There was a problem hiding this comment.
r+, looks good now thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func is_new_better logic update with back-end language update also