Skip to content
This repository was archived by the owner on Jan 25, 2018. It is now read-only.

Handle NULL defaultLocale (bug 1132488)#597

Merged
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:locale-tb
Feb 12, 2015
Merged

Handle NULL defaultLocale (bug 1132488)#597
kumar303 merged 1 commit intomozilla:masterfrom
kumar303:locale-tb

Conversation

@kumar303
Copy link
Contributor

This traceback was introduced by in-app JWTs
in bug 1131708

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this hard to parse for a moment - but I see now. A comment might be handy although the test will avoid this getting accidentally "factored" out. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully the test will keep it from getting refectored out ;) but yeah I'll add a note. This is a typical string problem in Python - original code was sloppy.

@muffinresearch
Copy link
Contributor

r+wc

This traceback was introduced by in-app JWTs
in bug 1131708
kumar303 added a commit that referenced this pull request Feb 12, 2015
Handle NULL defaultLocale (bug 1132488)
@kumar303 kumar303 merged commit 88d52f4 into mozilla:master Feb 12, 2015
@kumar303 kumar303 deleted the locale-tb branch February 12, 2015 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants