Bug 1173235: "Can't call method "id" without a package or object reference" when viewing a security bug

Author: globau

Bugzilla/Bug.pm

@@ -3913,6 +3913,7 @@ sub groups_in {
 
 sub in_group {
     my ($self, $group) = @_;
+    print STDERR 'bug ' . $self->id . " (" . $group->name . ")\n";
     return grep($_->id == $group->id, @{$self->groups_in}) ? 1 : 0;
 }
 

extensions/BMO/lib/Data.pm

@@ -141,7 +141,7 @@ our %group_change_notification = (
   'bugzilla-security'         => ['security@bugzilla.org'],
   'client-services-security'  => ['amo-admins@mozilla.org', 'web-security@mozilla.org'],
   'core-security'             => ['security@mozilla.org'],
-  'mozilla-services-security' => ['web-security@mozilla.org'],
+  'cloud-services-security'   => ['web-security@mozilla.org'],
   'tamarin-security'          => ['tamarinsecurity@adobe.com'],
   'websites-security'         => ['web-security@mozilla.org'],
   'webtools-security'         => ['web-security@mozilla.org'],
@@ -181,7 +181,7 @@ our @always_fileable_groups = qw(
 our %product_sec_groups = (
     "addons.mozilla.org"           => 'client-services-security',
     "Air Mozilla"                  => 'mozilla-employee-confidential',
-    "Android Background Services"  => 'mozilla-services-security',
+    "Android Background Services"  => 'cloud-services-security',
     "Audio/Visual Infrastructure"  => 'mozilla-employee-confidential',
     "AUS"                          => 'client-services-security',
     "Bugzilla"                     => 'bugzilla-security',
@@ -191,7 +191,7 @@ our %product_sec_groups = (
     "Developer Documentation"      => 'websites-security',
     "Developer Ecosystem"          => 'client-services-security',
     "Finance"                      => 'finance',
-    "Firefox Health Report"        => 'mozilla-services-security',
+    "Firefox Health Report"        => 'cloud-services-security',
     "Infrastructure & Operations"  => 'mozilla-employee-confidential',
     "Input"                        => 'websites-security',
     "Intellego"                    => 'intellego-team',

skins/contrib/Mozilla-OpenSans/global.css

@@ -66,7 +66,7 @@ body.bz_group_bugzilla-security {
 }
 
 body.bz_group_client-services-security,
-body.bz_group_mozilla-services-security {
+body.bz_group_cloud-services-security {
     background-image: url(noise.png), -moz-linear-gradient(#ffffa3, #ffffe3 400px);
     background-image: url(noise.png), -webkit-linear-gradient(#ffffa3, #ffffe3 400px);
     background-image: url(noise.png), linear-gradient(#ffffa3, #ffffe3 400px);

skins/contrib/Mozilla/global.css

@@ -109,7 +109,7 @@ body.bz_group_bugzilla-security {
 }
 
 body.bz_group_client-services-security,
-body.bz_group_mozilla-services-security {
+body.bz_group_cloud-services-security {
     background-image: url(noise.png), -moz-linear-gradient(#ffffa3, #ffffe3 400px);
     background-image: url(noise.png), -webkit-linear-gradient(#ffffa3, #ffffe3 400px);
     background-image: url(noise.png), linear-gradient(#ffffa3, #ffffe3 400px);

skins/custom/bug_groups.css

@@ -22,7 +22,7 @@ body.bz_group_bugzilla-security {
 }
 
 body.bz_group_client-services-security, 
-body.bz_group_mozilla-services-security {
+body.bz_group_cloud-services-security {
     background-color: #ffff80;
 }