fix AttributeError traceback upon saving new review: Spam.add (bug 771706)

Author: cvan

apps/reviews/models.py

@@ -175,18 +175,18 @@ class Spam(object):
     def add(self, review, reason):
         reason = 'amo:review:spam:%s' % reason
         try:
-            reasonset = cache.get('amo:review:spam:reasons')
+            reasonset = cache.get('amo:review:spam:reasons', set())
         except KeyError:
             reasonset = set()
         try:
-            idset = cache.get(reason)
+            idset = cache.get(reason, set())
         except KeyError:
             idset = set()
         reasonset.add(reason)
         cache.set('amo:review:spam:reasons', reasonset)
         idset.add(review.id)
         cache.set(reason, idset)
-
+        return True
 
     def reasons(self):
         return cache.get('amo:review:spam:reasons')

apps/reviews/tests/test_models.py

@@ -5,11 +5,11 @@
 
 import amo.tests
 from reviews import tasks
-from reviews.models import Review, GroupedRating, check_spam
+from reviews.models import check_spam, Review, GroupedRating, Spam
 
 
 class TestReviewModel(amo.tests.TestCase):
-    fixtures = ['base/apps', 'reviews/test_models.json']
+    fixtures = ['base/apps', 'reviews/test_models']
 
     def test_translations(self):
         translation.activate('en-US')
@@ -34,7 +34,7 @@ def test_translations(self):
 
 
 class TestGroupedRating(amo.tests.TestCase):
-    fixtures = ['base/apps', 'reviews/dev-reply.json']
+    fixtures = ['base/apps', 'reviews/dev-reply']
 
     def test_get_none(self):
         eq_(GroupedRating.get(3), None)
@@ -51,8 +51,12 @@ def test_cron(self):
 
 
 class TestSpamTest(amo.tests.TestCase):
-    # TODO: couldn't find tests covering spam, check coverage?
+    fixtures = ['reviews/test_models']
 
     def test_create_not_there(self):
-        assert not Review.objects.count()
+        Review.objects.all().delete()
+        eq_(Review.objects.count(), 0)
         check_spam(1)
+
+    def test_add(self):
+        assert Spam().add(Review.objects.all()[0], 'ball so hard')