don't allow or display ratings for apps in excluded regions (bug 879479)

Author: Allen Short

mkt/ratings/resources.py

@@ -21,6 +21,7 @@
 from mkt.api.base import CORSResource, MarketplaceModelResource
 from mkt.api.resources import AppResource
 from mkt.ratings.forms import ReviewForm
+from mkt.regions import get_region, REGIONS_DICT
 from mkt.versions.resources import VersionResource
 from mkt.webapps.models import Webapp
 from reviews.models import Review, ReviewFlag
@@ -80,12 +81,15 @@ def _review_data(self, request, app, form):
 
     def get_app(self, ident):
         try:
-            return Webapp.objects.valid().get(id=ident)
+            app = Webapp.objects.valid().get(id=ident)
         except (Webapp.DoesNotExist, ValueError):
             try:
-                return Webapp.objects.valid().get(app_slug=ident)
+                app = Webapp.objects.valid().get(app_slug=ident)
             except Webapp.DoesNotExist:
                 raise self.non_form_errors([('app', 'Invalid app')])
+        if not app.listed_in(region=REGIONS_DICT[get_region()]):
+            raise self.non_form_errors([('app', 'Not available in this region')])
+        return app
 
     def build_filters(self, filters=None):
         """

mkt/ratings/tests/test_resources.py

@@ -10,10 +10,11 @@
 from reviews.models import Review, ReviewFlag
 from users.models import UserProfile
 
+import mkt.regions
 from mkt.api.base import get_url, list_url
 from mkt.api.tests.test_oauth import BaseOAuth
 from mkt.site.fixtures import fixture
-from mkt.webapps.models import Webapp
+from mkt.webapps.models import AddonExcludedRegion, Webapp
 from versions.models import Version
 
 
@@ -90,6 +91,13 @@ def test_get_nonpublic(self):
         res, data = self._get_single(app=self.app.app_slug)
         eq_(res.status_code, 400)
 
+    def test_get_nonregion(self):
+        AddonExcludedRegion.objects.create(addon=self.app,
+                                           region=mkt.regions.BR.id)
+        self.client.cookies['region'] = 'br'
+        res, data = self._get_single(app=self.app.app_slug)
+        eq_(res.status_code, 400)
+
     def test_version_none(self):
         res, data = self._get_single()
         eq_(data['objects'][0]['version'], None)
@@ -207,6 +215,13 @@ def test_create_nonexistant_app(self):
         eq_(400, res.status_code)
         assert 'app' in data['error_message']
 
+    def test_create_for_nonregion(self):
+        AddonExcludedRegion.objects.create(addon=self.app,
+                                           region=mkt.regions.BR.id)
+        self.client.cookies['region'] = 'br'
+        res, data = self._create()
+        eq_(400, res.status_code)
+
     def test_create_for_nonpublic(self):
         self.app.update(status=amo.STATUS_PENDING)
         res, data = self._create()