Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Commit 78fc209

Browse files
committed
remove duplicate js in asset bundles, change submit review button text on review delete
1 parent a794b51 commit 78fc209

3 files changed

Lines changed: 8 additions & 14 deletions

File tree

media/css/mkt/detail.less

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -451,8 +451,7 @@ h1 .num {
451451

452452
#reviews-detail {
453453
min-height: 290px;
454-
margin-top: 40px;
455-
margin-bottom: 20px;
454+
margin-top: 40px 0 20px;
456455

457456
.review-stars-header {
458457
clear: right;
@@ -503,10 +502,10 @@ h1 .num {
503502
clear: left;
504503
margin-top: 14px;
505504
text-align: left;
506-
}
507-
.add-edit-review:after {
508-
top: 14px;
509-
right: 16px;
505+
&:after {
506+
top: 14px;
507+
right: 16px;
508+
}
510509
}
511510
.latest-reviews-list li {
512511
margin: 0;

media/js/mkt/ratings.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,9 @@
106106
$.post(action);
107107
setTimeout(function() {
108108
reviewEl.addClass('deleted');
109-
// If on detail page, change button text.
110-
$('.add-edit-review').text('Submit A Review');
109+
// Change edit review button to submit review button.
110+
$('.add-edit-review').text(gettext('Submit a Review'));
111+
$('#add-review').children().text(gettext('Add a Review'));
111112
if (reviewEl.hasClass('reply')) {
112113
var $parent = reviewEl.prev('.review');
113114
// If this was a reply, remove the "1 reply" link.

mkt/asset_bundles.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,4 @@
281281
'js/impala/suggestions.js',
282282
'js/mkt/lookup-tool.js',
283283
),
284-
'mkt/account': (
285-
'js/mkt/ratings.js',
286-
),
287-
'mkt/detail': (
288-
'js/mkt/ratings.js',
289-
),
290284
}

0 commit comments

Comments
 (0)