mail out pending refunds status (bug 719210)

Andy McKay · Andy McKay · commit d71067269c29 · 2012-03-02T20:12:04.000-05:00
diff --git a/apps/market/cron.py b/apps/market/cron.py
@@ -1,9 +1,16 @@
 from datetime import datetime, timedelta
 
-import amo
 import commonware.log
 import cronjobs
-from market.models import AddonPremium
+from jingo import env
+
+from django.conf import settings
+from django.db.models import Count
+
+from addons.models import Addon, AddonUser
+import amo
+from amo.utils import send_mail
+from market.models import AddonPremium, Refund
 
 log = commonware.log.getLogger('z.cron')
 
@@ -22,3 +29,37 @@ def clean_out_addonpremium(days=DAYS_OLD):
                  (obj.addon_id, obj.created))
         obj.delete()
 
+
+@cronjobs.register
+def mail_pending_refunds():
+    # First find all the pending refunds and the addons for them.
+    pending = dict((Refund.objects.filter(status=amo.REFUND_PENDING)
+                                  .values_list('contribution__addon_id')
+                                  .annotate(Count('id'))))
+    if not pending:
+        log.info('No refunds to email')
+        return
+    log.info('Mailing pending refunds: %s refunds found' % len(pending))
+
+    # Find all owners of those addons.
+    users = (AddonUser.objects.filter(role=amo.AUTHOR_ROLE_OWNER,
+                                      addon__in=pending.keys())
+                              .values_list('addon_id', 'user__email'))
+
+    # Group up the owners. An owner could have more than one addon and each
+    # addon can have more than one owner.
+    owners = {}
+    for addon_id, email in users:
+        owners.setdefault(email, [])
+        owners[email].append(addon_id)
+
+    # Send the emails out.
+    for owner, addon_ids in owners.items():
+        log.info('Sending refund emails to: %s about %s' %
+                 (email, ', '.join([str(i) for i in addon_ids])))
+        addons = Addon.objects.filter(pk__in=addon_ids)
+        ctx = {'addons': addons, 'refunds': pending}
+        send_mail('Pending refund requests at the Mozilla Marketplace',
+                  env.get_template('market/emails/refund-nag.txt').render(ctx),
+                  from_email=settings.NOBODY_EMAIL,
+                  recipient_list=[owner])
diff --git a/apps/market/templates/market/emails/refund-nag.txt b/apps/market/templates/market/emails/refund-nag.txt
@@ -0,0 +1,10 @@
+You have products at the Mozilla Marketplace that have pending refund requests and require your attention.  Please visit the URLs below to respond to these requests:
+
+{% for addon in addons %}
+    {{ addon.name }} ({{ ngettext('{0} request', '{0} requests', refunds[addon.pk])|f(refunds[addon.pk]) }})
+    {{ addon.get_dev_url('refunds')|absolutify }}
+{% endfor %}
+
+Thanks for your prompt response.  Your customers will appreciate it!
+
+- the Mozilla Marketplace Team
diff --git a/apps/market/tests/test_cron.py b/apps/market/tests/test_cron.py
@@ -1,12 +1,16 @@
 from datetime import datetime, timedelta
 
+from django.core import mail
+
 from nose.tools import eq_
 
 import amo
 import amo.tests
-from addons.models import Addon
-from market.models import AddonPremium
-from market.cron import clean_out_addonpremium
+from addons.models import Addon, AddonUser
+from market.cron import clean_out_addonpremium, mail_pending_refunds
+from market.models import AddonPremium, Refund
+from stats.models import Contribution
+from users.models import UserProfile
 
 
 class TestCronDeletes(amo.tests.TestCase):
@@ -30,3 +34,67 @@ def test_doesnt_delete(self):
         clean_out_addonpremium(days=1)
         eq_(AddonPremium.objects.count(), 3)
 
+
+class TestPendingRefunds(amo.tests.TestCase):
+    fixtures = ['webapps/337141-steamcube', 'base/users']
+
+    def create_refund(self, webapp=None):
+        webapp = webapp if webapp else self.webapp
+        contribution = Contribution.objects.create(addon=webapp)
+        return Refund.objects.create(contribution=contribution)
+
+    def setUp(self):
+        self.webapp = Addon.objects.get(pk=337141)
+        self.author = self.webapp.authors.all()[0]
+        self.refund = self.create_refund()
+
+    def test_none(self):
+        self.refund.delete()
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 0)
+
+    def test_not_pending(self):
+        for status in [amo.REFUND_APPROVED, amo.REFUND_APPROVED_INSTANT,
+                       amo.REFUND_DECLINED]:
+            self.refund.update(status=status)
+            mail_pending_refunds()
+        eq_(len(mail.outbox), 0)
+
+    def test_single(self):
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 1)
+        assert str(self.webapp.name) in mail.outbox[0].body
+        assert '1 request' in mail.outbox[0].body
+        assert mail.outbox[0].to == [self.author.email]
+
+    def test_plural(self):
+        self.create_refund()
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 1)
+        assert '2 requests' in mail.outbox[0].body
+
+    def test_two_owners(self):
+        user = UserProfile.objects.exclude(pk=self.author.pk)[0]
+        AddonUser.objects.create(user=user, addon=self.webapp)
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 2)
+        emails = set([m.to[0] for m in mail.outbox])
+        eq_(set([self.author.email, user.email]), emails)
+
+    def test_one_owner_one_other(self):
+        user = UserProfile.objects.exclude(pk=self.author.pk)[0]
+        AddonUser.objects.create(user=user, addon=self.webapp,
+                                 role=amo.AUTHOR_ROLE_VIEWER)
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 1)
+        assert mail.outbox[0].to == [self.author.email]
+
+    def test_two_addons(self):
+        other = Addon.objects.create(app_slug='something-else',
+                                     name='cthulhu', type=amo.ADDON_WEBAPP)
+        AddonUser.objects.create(user=self.author, addon=other,
+                                 role=amo.AUTHOR_ROLE_OWNER)
+        self.create_refund(other)
+        mail_pending_refunds()
+        eq_(len(mail.outbox), 1)
+        eq_(mail.outbox[0].body.count('1 request'), 2)
diff --git a/scripts/crontab/crontab.tpl b/scripts/crontab/crontab.tpl
@@ -42,6 +42,7 @@ HOME=/tmp
 30 1 * * * {{ z_cron }} update_user_ratings
 40 1 * * * {{ z_cron }} update_weekly_downloads
 50 1 * * * {{ z_cron }} gc
+30 2 * * * {{ z_cron }} mail_pending_refunds
 30 3 * * * {{ django }} cleanup
 30 4 * * * {{ z_cron }} cleanup_synced_collections
 30 5 * * * {{ z_cron }} expired_resetcode
