fix UnicodeDecodeError (bug 941480)

Author: cvan

mkt/developers/tasks.py

@@ -231,8 +231,7 @@ class ResponseTooLargeException(Exception):
 def get_content_and_check_size(response, max_size):
     # Read one extra byte. Reject if it's too big so we don't have issues
     # downloading huge files.
-    content = response.iter_content(chunk_size=max_size + 1,
-                                    decode_unicode=True).next()
+    content = response.iter_content(chunk_size=max_size + 1).next()
     if len(content) > max_size:
         raise ResponseTooLargeException('Too much data.')
     return content

mkt/developers/tests/test_tasks.py

@@ -366,6 +366,11 @@ def test_strip_utf8_bom(self):
                 ur.iter_content.return_value = mock.Mock(next=lambda: content)
 
         tasks.fetch_manifest('url', self.upload.pk)
+
+        # Should not be called with anything else (e.g., `decode_unicode`).
+        ur.iter_content.assert_called_with(
+            chunk_size=settings.settings.MAX_WEBAPP_UPLOAD_SIZE + 1)
+
         upload = self.get_upload()
         with storage.open(upload.path, 'rb') as fp:
             manifest = fp.read()