change app name max_length to 128 characters for Edit Listing page (bug 703936)

Author: cvan

apps/addons/forms.py

@@ -190,6 +190,11 @@ def clean_slug(self):
         return target
 
 
+class AppFormBasic(AddonFormBasic):
+    """Form to override name length for apps."""
+    name = TransField(max_length=128)
+
+
 class ApplicationChoiceField(forms.ModelChoiceField):
 
     def label_from_instance(self, obj):

apps/devhub/tests/test_views_edit.py

@@ -133,6 +133,16 @@ def test_appslug_visible(self):
         eq_(pq(r.content)('#slug_edit').remove('a').text(),
             u'/\u2026/%s' % self.webapp.app_slug)
 
+    def test_edit_name_required(self):
+        r = self.client.post(self.edit_url, self.get_dict(name=''))
+        self.assertFormError(r, 'form', 'name', 'This field is required.')
+
+    def test_edit_name_max_length(self):
+        r = self.client.post(self.edit_url, self.get_dict(name='x' * 129))
+        self.assertFormError(r, 'form', 'name',
+                             'Ensure this value has at most 128 characters '
+                             '(it has 129).')
+
     def test_edit_slug_success(self):
         webapp = self.webapp
         data = self.get_dict()

apps/devhub/views.py

@@ -968,7 +968,8 @@ def ajax_dependencies(request, addon_id, addon):
 @dev_required(webapp=True)
 def addons_section(request, addon_id, addon, section, editable=False,
                    webapp=False):
-    models = {'basic': addon_forms.AddonFormBasic,
+    basic = addon_forms.AppFormBasic if webapp else addon_forms.AddonFormBasic
+    models = {'basic': basic,
               'media': addon_forms.AddonFormMedia,
               'details': addon_forms.AddonFormDetails,
               'support': addon_forms.AddonFormSupport,