feat: remove sandbox mode on rokt kit#22
Merged
Conversation
Collaborator
alexs-mparticle
left a comment
alexs-mparticle
left a comment
There was a problem hiding this comment.
LGTM, but I'm not sure if I have all the context as to why this is being changed. If @rmi22186 approves, I'm good with you (squash and) merging
Collaborator
|
Looks fine. |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
## [1.2.1](v1.2.0...v1.2.1) (2025-04-16) ### Bug Fixes * Remove sandbox mode on rokt kit ([#22](#22)) ([58f8ae5](58f8ae5))
crisryantan
added a commit
that referenced
this pull request
Apr 17, 2025
* development: chore(release): 1.2.1 [skip ci] chore(build): Generate latest bundle [skip ci] fix: Remove sandbox mode on rokt kit (#22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a continuation of the changes in mparticle-web-sdk where we explicitly add sandbox attribute when calling selectPlacements depending on SDKInitConfig.isDevelopmentMode. Passing sandbox mode to createLauncher is no longer needed
Testing Plan
{explain how this has been tested, and what additional testing should be done}
Local unit tests passing