feat: enrich commerce event action from Rokt.CommerceEventType#97
Open
jaissica12 wants to merge 1 commit into
Open
feat: enrich commerce event action from Rokt.CommerceEventType#97jaissica12 wants to merge 1 commit into
jaissica12 wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds commerce event type enrichment to the Rokt Kit. When the core SDK populates a
Rokt.CommerceEventTypecustom flag on new commerce event types (e.g.,payment_succeeded,view_cart), the Kit reads this flag and overridesproduct_action.actionfrom"unknown"to the actual event name before sending the batch to__batch_stream__.This is the Kit-side counterpart to the core SDK PR #1269
Changes
enrichCommerceEventTypes()private method toRoktKit— iterates batch events, skips non-commerce events, readscustom_flags['Rokt.CommerceEventType'], and overridesproduct_action.actionprocessBatch()beforesendBatchStream()so enrichment happens just before__batch_stream__actionremains"unknown")Testing Plan
#enrichCommerceEventTypesdescribe block:actionwith custom flag value for commerce events[Forwarder] Batch sent to Kitshowsaction: "unknown"[Rokt Kit] After enrichmentshowsaction: "payment_succeeded"action: "unknown"(unaffected)