fix: use mParticle config logging flag#98
Merged
Conversation
rmi22186
force-pushed
the
fix/use-mparticle-config-logging-setting
branch
from
bb3ce06 to
d339829
Compare
crisryantan
reviewed
May 21, 2026
| accountId: string | null | undefined, | ||
| rateLimiter?: RateLimiter, | ||
| ) { | ||
| const isLoggingEnabled = config?.isLoggingEnabled === true || config?.isLoggingEnabled === 'true'; |
Collaborator
Author
There was a problem hiding this comment.
so even this code previously was technically wrong and no one caught it. because MPServer actually sends things back as "True" and not "true", or true. 🙃
crisryantan
approved these changes
May 21, 2026
alexs-mparticle
approved these changes
May 21, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 22, 2026
## [1.26.2](v1.26.1...v1.26.2) (2026-05-22) ### Bug Fixes * use mParticle config logging flag ([#98](#98)) ([1973f5c](1973f5c))
Collaborator
|
🎉 This PR is included in version 1.26.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoggingEnabledlives on themParticle.configand not in the kit settings.Testing Plan
Tested locally and successfully got logs in the dashboard.