fix(parser): fall back from (( … )) arith to nested subshells#48
Merged
Conversation
Bash resolves the `((` ambiguity by tentatively parsing as an arithmetic command and re-parsing as two nested subshells `( ( … ) )` when the body is not a valid arithmetic expression. Rable committed to arith as soon as it saw `((` and errored out on e.g. `((x\n> 0)\n)`. Add a small `LexerCheckpoint` save/restore API to `Lexer` and wrap the `((` dispatch in `parse_command_inner` with a try-then-fallback: on a `MatchedPair` error from `read_until_double_paren` (the precise signal that `))` couldn't be found at depth 0), rewind and call `parse_subshell` instead. Other arith-side errors still propagate. Closes #42. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mpecan
pushed a commit
that referenced
this pull request
Apr 19, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.0](rable-v0.1.15...rable-v0.2.0) (2026-04-18) ### ⚠ BREAKING CHANGES * tighten lexer API surface and relocate WordSpan to ast ([#70](#70)) ### Bug Fixes * **format:** align cmdsub reformatter with bash canonical form ([#49](#49)) ([c7a4411](c7a4411)) * **lexer:** accept sloppy heredoc terminator in cmdsub mode ([#50](#50)) ([40f394f](40f394f)) * **lexer:** backticks opaque when content is invalid ([#71](#71)) ([e72166f](e72166f)), closes [#38](#38) * **lexer:** disable reserved-word recognition after assignment words ([#44](#44)) ([42e1fc0](42e1fc0)) * **lexer:** stop treating ]] and unbalanced [...] as special outside conditionals ([#45](#45)) ([4bf5a5c](4bf5a5c)) * **parser:** fall back from (( … )) arith to nested subshells ([#48](#48)) ([1437f00](1437f00)) ### Code Refactoring * **format:** introduce Formatter struct ([#65](#65)) ([d965a8f](d965a8f)) * **lexer:** drop Result<Token> wrapper from operator readers ([#62](#62)) ([d52a841](d52a841)) * **lexer:** split read_word_token into classify + advance + dispatch helpers ([#63](#63)) ([3ba09f5](3ba09f5)) * **parser:** extract fill_heredoc_contents visitor helpers ([#68](#68)) ([40e6165](40e6165)) * **parser:** extract helpers from three oversize parsers ([#69](#69)) ([25d0762](25d0762)) * **sexp:** dispatch NodeKind Display to per-category helpers ([#66](#66)) ([44b0330](44b0330)) * **sexp:** table-drive ANSI-C escape dispatch ([#67](#67)) ([91a5267](91a5267)) * tighten lexer API surface and relocate WordSpan to ast ([#70](#70)) ([5171d01](5171d01)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: repository-butler[bot] <166800726+repository-butler[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
((…))→ nested-subshell fallback that bash's parser performs when the body of((…))is not a valid arithmetic expression. Input like((x\n> 0)\n)is now parsed as two nested subshells instead of failing withexpected )), got Eof.LexerCheckpointsave/restore API (pos,line,peeked,last_token_end) onLexer. The arith dispatch inparse_command_innernow triesparse_arith_commandfirst and, on aRableError::MatchedPairfromread_until_double_paren, restores the checkpoint and re-parses viaparse_subshell. Other arith-side errors still propagate.reserved_word_as_word 2fromKNOWN_ORACLE_FAILURESintests/integration.rs.Closes #42.
Test plan
cargo fmtcargo clippy --all-targets -- -D warnings— no warningscargo test— 238 passed, 0 failedsrc/parser/tests.rs:arith_command_with_inner_parens—(( (1+2) ))still parses as arithmeticdouble_paren_falls_back_to_nested_subshells— the exact issue inputdouble_paren_fallback_preserves_following_command— lexer state is clean after fallbackdouble_paren_fallback_inside_if— fallback works when dispatched from inside a compound constructreserved_word_as_word 2now passes inoracle_bash_valid_divergences