Fix setting rbsp_trailing_bits and Unregistered User Data SEI payload_size#159
Merged
dariusz-f merged 2 commits intompeg5:masterfrom Feb 24, 2026
Merged
Fix setting rbsp_trailing_bits and Unregistered User Data SEI payload_size#159dariusz-f merged 2 commits intompeg5:masterfrom
dariusz-f merged 2 commits intompeg5:masterfrom
Conversation
The value was being unnecesarly converted to bits, resulting in broken SEI NALUs. Signed-off-by: James Almer <jamrial@gmail.com>
Section 7.3.2.8 from ISO/IEC 23094-1:2020 states a rbsp_stop_one_bit must be written, before the zeroes that align to the next byte boundary. Signed-off-by: James Almer <jamrial@gmail.com>
dariusz-f
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 7.3.2.8 from ISO/IEC 23094-1:2020 states a rbsp_stop_one_bit must be written before the zeroes that align to a byte boundary.
I don't have access to the 2023 amendment of the spec, but i very much doubt it changed the syntax of rbsp_trailing_bits().
As for SEI, the value of payload_size was being unnecessarily converted to bits, resulting in broken SEI NALUs.