This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Closed
Conversation
…ls the rfr module within the root node_modules and not as part of the stylemark package node_modules. We can fix the path issues with setting the Root relative to its loaded file.
Owner
|
Thanks for taking the time to look into this issue and for your patience! I'm a big fan of this idea: It is better to fix a bug by removing rather than adding code. Due to the flat nature of the source files, |
mpetrovich
added a commit
that referenced
this pull request
Dec 16, 2018
Due to the simple project file hierarchy, node-rfr doesn't add much value and also causes issues such as #59
Owner
|
Fixed in v3.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I forked your project and doing some changes.
I then use my package as dependency on an other client project.
The problem now is, that
npm installsomehow installs the rfr module in the client projectsnode_modulesinstead of within the stylemark package (node_modules/stylemark/node_modules) which would solve the problem.I don't understand yet completely why this is happening, and why
doesn't work as expected...
This is of course problematic, because you then use the RFR module to build up the file paths and this is in the wrong location.
Solution
I could fix the path issues with setting the Root relative to its loaded file.
Within
bin/stylemark:Feature Sponsored by
If you like this change, feel free to review and accept this PR ;)
This feature/PR is sponsored by the company I work: Garaio AG