CoMD debug #418
Merged
CoMD debug #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gc00
approved these changes
Feb 11, 2025
Collaborator
gc00
left a comment
gc00
left a comment
There was a problem hiding this comment.
I'm approving this in advance. Please note my two comments and fix them.
Also, after pushing this in, please let @xuyao0127 know, so that he can add this commit to his development branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following commits:New test for MPI_Double_Int datatype with MPI_Allreduce: MANA fails to resolve MPI_Double_Int for a call to MPI_Allreduce CoMD software. This commit adds a small and faster toy program to MANA's test directory for quickly filtering similar failures in future.Fixed upper_to_lower_constants lookup for special(negative) Datatypes: Special Datatypes are defined in MPI library for 'struct' type datatypes, defined as negative constant values. This commit aims to maintain integrity of these special(negative) datatype when passed in function calls.