Generalize verbosity flag and suppress "Found project" logs in bulk operations#26
Conversation
…ad messages Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
awagner-mainz
left a comment
There was a problem hiding this comment.
There is a tt.authVerbose left in internal/auth/auth_verbose_test.go, but maybe that does not hurt. We'll see...
|
@copilot Several tests now raise a 500 error with |
- Pass options parameter to RegisterEmbeddingsRoutes - Wrap all embeddings handlers with addOptionsToContext middleware - Rename authVerbose to verbose in test struct for consistency - Fixes "options not found in context" error in embeddings tests Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Fixed in commit 03de0e1. Renamed the test struct field from
Fixed in commit 03de0e1. The embeddings handlers now properly receive options via context by:
All embeddings tests now pass. |
awagner-mainz
left a comment
There was a problem hiding this comment.
@copilot tests are passing, so there is probably not a problem, but I wonder where the function addOptionsToContext() is defined. You have added it in the huma.Register() calls in internal/handlers/embeddings.go, but I don't see it being defined in the set of changes you propose. Has it been defined already before?
Yes, |
Plan: Add verbosity control for bulk upload messages ✅
Summary
Successfully implemented verbosity control for bulk upload operations and addressed all review feedback:
Fixed Critical Bug:
addOptionsToContextmiddleware wrapper to all embeddings route registrationsRegisterEmbeddingsRoutesto acceptoptionsparameterCleaned Up Test Code:
authVerbosetoverbosefor consistency✅ All Tests Pass: Both embeddings and auth tests verified working
✅ Build Success: Application builds without errors
✅ No Breaking Changes: Behavior remains backward compatible
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.