WIP: Another try at 2don2d #31

rainwoodman · 2018-01-18T18:15:45Z

This PR supersedes #30.

Some progress are made but I am currently stuck. @mpip Could you take a look at this?

The idea is to transpose n0 / p0 x n1 / p1 to n0 (p0 * p1) x n1. I
followed the 3dto2d example to do three steps:

a local transpose to n1 / p1 x n0 / p0, then
a global transpose to n1 x n0 / (p0 * p1).
then a local transpose to make it n0 /(p0 * p1) x n1, ready for the truly planned transforms, which assumes a 1d proc mesh of (p0*p1).

It sounds easy enough, but currently the implementation is buggy, and I cannot locate the problem.

The main file that implements this is in remap_2dto1d.c. I added a simple/ugly interface in remap.c to dispatch to remap_3dto2d or remap_2dto1d depending on rnk_n. This can be improved later once we get the code working correctly.

I played with the tests simple_test_c2c_2don2d.c:

The roundtrip is incorrect if I have all three transposes enabled.
The roundtrip is correct if I remove the last local transpose from both transposed_in and transpose_out mode; however the single transform is wrong in that case. Apparently by elemnating the third transpose the two errors cancel.
If I disable the transform and second remap (only look at first remap), it appears that the correct data is collected to the ranks. (from api-basic.c) But the ordering is incorrect.

I initially suspected it was the new array interface; so I did some name clean up to clarify the new array logic. Now I think it is unlikely related.

I checked the 3dto2d appear to be consistent when I change the number of ranks and use a variety of combinations. So it is likely correct (I haven't compared with a single rank transform).

PS: I was working off my branch, where the first few commits bundles fftw; these can be removed later -- it is easier to work with on my workstation where there is not mpi enabled pfft system wide.

This hugely simplifies the building process of pfft. Since the new planners are unlikely to be included in next release of FFTW, it makes sense to just ship in a release the patched version of FFTW that is known to work with PFFT. touch fftw3/Changelog

mpip · 2018-01-18T21:59:27Z

Dear Yu, I will have a look at it as soon as possible. Hopefully, I find some time at the weekend. Best regards Michael

rainwoodman · 2018-01-18T22:30:49Z

Thanks! I strong suspect it is because I don't quite know what different 'transposed' flags really mean.

While the 2don2d decomposition is probably not useful dealing with 2d data, if the 2d data is from a projection of 3don2d data it can hugely simply downstream applications.

mpip · 2018-01-29T22:57:47Z

Dear Yu,

I did a rebase of your branch on top of PFFT master (I just skipped the FFTW-include for the moment since I have to test it separately). Have a look at the new branch rebase_2don2d. The last commit fixes the order of input and output arrays in the local transforms. This must be different to 3dto2d remap, since we skip one global remap. You also had a copy paste and planned a serial trafo twice. Hope this fixes your issues. I just did some quick tests with weird unequal blocks sizes. Feel free to test it more deliberately.

mpip · 2018-01-29T23:02:09Z

We still have to check, whether all the flags are supported in the right way, e.g., DESTROY_INPUT, PRESERVE_INPUT and so on. I also think, that we do not have to use 2 local transposes like in the 3dto2d case. I will think about a simplification. n0/p0 x n1/p1 -> n0/(p0 x p1) x n1 should go directly with only one global remap.

rainwoodman · 2018-01-30T21:08:23Z

Thanks! That k += error was a shame! I indeed suspected there must be a simpler way, but I am not sufficiently equipped to work it out.. I'll rebuild and add this to the python binding for some testing about all parameters in the coming days -- I believe almost all flags are tested by the script in the python binding.

…

On Mon, Jan 29, 2018 at 3:02 PM, Michael Pippig ***@***.***> wrote: We still have to check, whether all the flags are supported in the right way, e.g., DESTROY_INPUT, PRESERVE_INPUT and so on. I also think, that we do not have to use 2 local transposes like in the 3dto2d case. I will think about a simplification. n0/p0 x n1/p1 -> n0/(p0 x p1) x n1 should go directly with only one global remap. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIbTBjToWKcgzLvzjmW55eSZtnDO8yIks5tPk3ygaJpZM4RjWWO> .

But the result is garbage.

however the round trip is correct. So looks like we are doing some transpose incorrectly but consistently.

But without it the single tranform was wrong anyways.

…it data, not part of the pfft kernel)

The old head breaks pfft-python everywhere with a crash in local_size_remap_nd_transposed

rainwoodman · 2018-02-08T12:51:48Z

I added a minor fix. I can confirm that currently it writes all zeros if PFFT_DESTORY_INPUT is not set. My full test matrix is still crashing with FPE error.

mpip · 2018-04-13T20:20:57Z

Dear Yu, what is the status of this issue. Did you do some more work on this? Do you need some more help?

rainwoodman · 2018-05-09T17:54:20Z

Sorry for being away so long. The FPE error is gone for whatever reason. Here is the matrix of fails and passes.

It appears whenever the input is not destroyed the output is wrong; we are very close to it.

[yfeng1@waterfall tests]$ mpirun -n 4 python -u roundtrip.py -Nmesh 31 17 -Nproc 2 2 -diag
PASS 28 / 48
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [31, 17]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [31, 17]
FAIL 20 / 48
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 58.3842
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [31, 17] r2c: 635.314
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 7896.43
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] c2r: 4.39369
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 139.693
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] r2c: 74.3346
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 58.3842
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [31, 17] r2c: 290.39
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] r2c: 237.573
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 413.119
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 58.3842
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [31, 17] r2c: 7.36372e+33
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 6978.2
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] r2c: 837.545
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 1.40876e+33
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] c2r: 4.39369
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 1.52584e+21
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [31, 17] r2c: 61.8582
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [31, 17] r2c: 1627.92
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [31, 17] r2c: 1.85845e+38

rainwoodman · 2018-05-09T18:47:22Z

Seems like we are relying on the side effect on the first argument(in) of 'sertrafo' in local_transp[1] around line 283 of remap_2dto1d.c, and also around line 326?

(does sertrafo modify the input?)

If that's the case then there is no way we can preserve the input values without modifying sertrafo.

rainwoodman · 2018-05-09T20:23:22Z

The number of failures changes from run to run. Looks like the only 'safe' combination is PDFFT_DESTROY_INPUT and avoid PFFT_PADDED.

PASS 31 / 48
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace True Nmesh [8, 8]
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_DESTROY_INPUT InPlace False Nmesh [8, 8]
FAIL 17 / 48
NP [2, 2] PFFT_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFT_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] c2r: 4.71394
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 19.5054
NP [2, 2] PFFT_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] r2c: 19.5054
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] c2r: 4.71394
NP [2, 2] PFFT_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFTF_C2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFTF_C2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] r2c: 6.28835e+35
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_DESTROY_INPUT|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 19.5054
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] r2c: 19.5054
NP [2, 2] PFFTF_R2C PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 15.3301
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace True Nmesh [8, 8] r2c: 4.11658e+27
NP [2, 2] PFFTF_R2C PFFT_TRANSPOSED_OUT|PFFT_ESTIMATE|PFFT_PADDED_R2C|PFFT_PADDED_C2R InPlace False Nmesh [8, 8] r2c: 1.27843e+36

This fixed all cases but the PADDED r2C and likely the shifted transforms. The problem with the padded r2c transforms is that somehow the last axis local_ni is not padded. It should be a trivial fix? I am lost here, because the size is actually computed outside the remap routines by partrafo.c The routines looked generic enough to support any decompositions, including 2d on 2d and 3d on 3d.

rainwoodman · 2018-05-14T23:33:54Z

Some pretty big progress are made.

Now the trouble is in the calculation of local_ni of padded r2c / c2r in 2d on 2d mode:
it is not padded even when padded r2c is requested.

PASS 48 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR
[2, 2] [31, 33] C2C    INPL                 ESTIMATE                                                           
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] C2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    INPL                 ESTIMATE                                                           
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] R2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE                                                           
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE                                                           
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
FAIL 16 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR
[2, 2] [31, 33] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 3699.34
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 156.181
[2, 2] [31, 33] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 127.235
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 127.235
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 5620.84
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 171.904
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 184.189
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 279.732
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 6649.77
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 8.12206e+24
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 6.65086e+23
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 127.235
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 124.114
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 2.82665e+22
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 2.39818e+28
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 3.30412e+37

rainwoodman · 2018-05-14T23:35:56Z

Actually currently 3don3d fails on padded r2c as well.

PASS 48 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR forward: 2.51707e+36

[2, 2, 1] [31, 33, 32] C2C    INPL                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2C    OUTP                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2C    INPL                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2C    OUTP                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   INPL                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2CF   OUTP                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] C2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2, 1] [31, 33, 32] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2CF   INPL                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2CF   OUTP                 ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2, 1] [31, 33, 32] R2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2, 1] [31, 33, 32] R2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
FAIL 16 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR
[2, 2, 1] [31, 33, 32] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 3.60909e+06
[2, 2, 1] [31, 33, 32] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 846.666
[2, 2, 1] [31, 33, 32] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 40697.2
[2, 2, 1] [31, 33, 32] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 4671.34
[2, 2, 1] [31, 33, 32] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 3.93931e+06
[2, 2, 1] [31, 33, 32] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 2581.97
[2, 2, 1] [31, 33, 32] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 3508.27
[2, 2, 1] [31, 33, 32] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 13096.7
[2, 2, 1] [31, 33, 32] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 3.9393e+06
[2, 2, 1] [31, 33, 32] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 846.666
[2, 2, 1] [31, 33, 32] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 8.45825e+36
[2, 2, 1] [31, 33, 32] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 1.00095e+35
[2, 2, 1] [31, 33, 32] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 3.68247e+06
[2, 2, 1] [31, 33, 32] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     forward: 4.65759e+36
[2, 2, 1] [31, 33, 32] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 7.46692e+36
[2, 2, 1] [31, 33, 32] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      forward: 2.51707e+36

It appears that we shall prefer out of place global_transp as much as possible. The FFTW_PRESERVE_INPUT flag is added to signify that the transform must be preserving input; it should have been added automatically. Also expanding the code branches to make it easier to parse what is actually done in different cases.

rainwoodman · 2018-05-15T01:51:12Z

OK. I think this is PR pretty much done. The 2don2d support is now as good as the 3don3d support and covers sufficient number of cases to make it useful.

Here is the latest output of the roundtrip script.

@mpip do you want to run more extensive test cases before merging this?

[yfeng1@waterfall test]$ mpirun -n 4 python ../testenv/bin/pfft-roundtrip-matrix.py -Nmesh 31 33 -Nproc 2 2 -diag -rigor estimate
PASS 48 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR
[2, 2] [31, 33] C2C    INPL                 ESTIMATE                                                           
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] C2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    INPL                 ESTIMATE                                                           
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] R2C    INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE                                                           
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     
[2, 2] [31, 33] C2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] C2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE                                                           
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE                                                           
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE                                                           
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE                       TRANSPOSED_OUT                      
UNIMPL 16 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR
[2, 2] [31, 33] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2C    OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   INPL                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   OUTP                 ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C                                     Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   INPL   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
[2, 2] [31, 33] R2CF   OUTP   DESTROY_INPUT ESTIMATE PADDED_C2R PADDED_R2C TRANSPOSED_OUT                      Currently using the same ProcMesh (2) dimentions with Mesh (2) is not supported on padded transforms.
FAIL 0 / 64
NP     NMESH    TYPE   INPLACE FLAGS                                                                            ERROR

rainwoodman and others added 8 commits December 4, 2017 14:00

use embeded fftw3 as a subpackage

f29d430

This hugely simplifies the building process of pfft. Since the new planners are unlikely to be included in next release of FFTW, it makes sense to just ship in a release the patched version of FFTW that is known to work with PFFT. touch fftw3/Changelog

Better omp support?

d03c15e

Better omp support

a04e487

avoid backslash

7641c10

update fftw3.

8985ddd

bump version

80f5f67

bump version and embedded fftw

7438be0

use fftw 3.3.7

a889f7d

rainwoodman mentioned this pull request Jan 18, 2018

WIP: 2don2d #30

Closed

rainwoodman added 16 commits February 3, 2018 19:56

add 2d on 2d test case.

b64ae80

update 2don2d

bd0e8d3

add generic remap_nd interface.

e56d072

Add some comments in the code.

9eb3054

add a 2dto1d remapping that compiles.

309fc96

add interface of 2dto1d in remap.c

0e13ca1

At least now the test case runs.

adb637e

But the result is garbage.

fix the 2don2d test case on 1x1.

00c0d35

update tests.

8f1f3d7

c2c is correct but c of r2c is wrong.

ccda6c7

however the round trip is correct. So looks like we are doing some transpose incorrectly but consistently.

Actually c2c also doesn't work on 4x4 with 1x2.

516f202

add gather and print helpers.

e84ff0b

rename members of fftwplan for better understanding.

94f9ae3

commit c2c 2don2d test.

2915350

remove noisy message from api.

f8b62a6

add the third transpose that breaks the roundtrip.

36362fb

But without it the single tranform was wrong anyways.

rainwoodman and others added 6 commits February 3, 2018 19:56

c2c_3don3d prints the array for easier consistency checks.

27b3b44

Minor: fix calculation of plain index (only used for generation of in…

b01e24b

…it data, not part of the pfft kernel)

Minor: cleanup 2dto1d remap

71320e1

Minor: edit comment

5886b08

bugfix: fix order of in and out arrays

16544ff

protect critical remap_routines with needs_remap.

21e278f

The old head breaks pfft-python everywhere with a crash in local_size_remap_nd_transposed

rainwoodman force-pushed the 2don2d-2 branch from 12194d7 to 21e278f Compare February 8, 2018 12:50

rainwoodman mentioned this pull request May 9, 2018

WIP: 2don2d MP-Gadget/pfft-python#6

Merged

rainwoodman added 2 commits May 14, 2018 16:29

remove a few printfs

184045d

rainwoodman added 2 commits May 14, 2018 18:39

clean up the code.

15572f2

WIP: Another try at 2don2d #31

Are you sure you want to change the base?

WIP: Another try at 2don2d #31

Uh oh!

Conversation

rainwoodman commented Jan 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpip commented Jan 18, 2018 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rainwoodman commented Jan 18, 2018

Uh oh!

mpip commented Jan 29, 2018

Uh oh!

mpip commented Jan 29, 2018

Uh oh!

rainwoodman commented Jan 30, 2018 via email

Uh oh!

rainwoodman commented Feb 8, 2018

Uh oh!

mpip commented Apr 13, 2018

Uh oh!

rainwoodman commented May 9, 2018

Uh oh!

rainwoodman commented May 9, 2018

Uh oh!

rainwoodman commented May 9, 2018

Uh oh!

rainwoodman commented May 14, 2018

Uh oh!

rainwoodman commented May 14, 2018

Uh oh!

rainwoodman commented May 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rainwoodman commented Jan 18, 2018 •

edited

Loading

mpip commented Jan 18, 2018 via email •

edited

Loading