Fix Marshallable's fromCC #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that property value is defined by wrapping in Option rather than comparing to null, fixes compiler warnings on value's whose types can never be null.
Owner
|
Ah, declaring the list type is a nicer way of handling those edge cases. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back a fix that was removed in 3.3.4.7 to avoid compiler warnings when a property value's type cannot be null.
Since updating to 3.3.4.7, we've also been seeing dead code errors after calls to the DSL's select step. This PR also addresses this issue. Unfortunately, I have not yet been able to get a simple reproducible example together to contribute to DSLSpec, however it would appear to also be related to the fix for #265. Fundamentally, the problem in #265 occurs when fromCCParams is empty. When the empty fromCCParams gets spliced into immutable.List.apply, the type of the resulting List is
List[Nothing](hence the _2 is not a member of Nothing errors). Explicitly providing a type parameter to List fixes the issues.