Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Remove marker if AllAlivePlayersList no longer contains player#16

Merged
mpstark merged 1 commit into
mpstark:mainfrom
ArchangelWTF:fix/despawn-bot-markers
Jul 14, 2024
Merged

Remove marker if AllAlivePlayersList no longer contains player#16
mpstark merged 1 commit into
mpstark:mainfrom
ArchangelWTF:fix/despawn-bot-markers

Conversation

@ArchangelWTF
Copy link
Copy Markdown
Contributor

This fixes a bug where mods like SWAG + Donuts despawn AI but the marker stays on the map, tested with a quick testing function and seems to now have the proper behavior.

@mpstark mpstark merged commit c15dd99 into mpstark:main Jul 14, 2024
@mpstark
Copy link
Copy Markdown
Owner

mpstark commented Jul 14, 2024

Thanks for the PR. I will release a version with this fix in it soon.

@mpstark
Copy link
Copy Markdown
Owner

mpstark commented Jul 14, 2024

I changed the logic a bit in a follow up commit to avoid expressing AllAlivePlayersList through LINQ too many times and generating some extra garbage. Do you mind testing with your setup to see if this change still removes these inactive bots?

DynamicMaps-0.3.2-5ae3f601-inactive-players.zip

@ArchangelWTF
Copy link
Copy Markdown
Contributor Author

@mpstark In my testing it that works fine, so I think we're good to go for this release.

In FIKA we're also working to get better compatibility for other mods to airdrops, so either in this version or the next those should appear on the map as well as you've had it as an issue for some-time now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants