Skip to content

Enable HTTP/2 extended CONNECT from ProxyConfig#2

Draft
mpuncel wants to merge 1 commit into
masterfrom
mpuncel/websocket-grpc-coexistence
Draft

Enable HTTP/2 extended CONNECT from ProxyConfig#2
mpuncel wants to merge 1 commit into
masterfrom
mpuncel/websocket-grpc-coexistence

Conversation

@mpuncel
Copy link
Copy Markdown
Owner

@mpuncel mpuncel commented May 9, 2026

🤖 Reworked this draft so HTTP/2 extended CONNECT is configured through the ProxyConfig CRD instead of proxy environment metadata.

Summary:

  • Consumes API draft Add extended CONNECT setting to ProxyConfig api#2 via a temporary replace istio.io/api => github.com/mpuncel/api ....
  • Adds generated CRD schema for ProxyConfig enableHttp2Connect.
  • Maps networking.istio.io/v1beta1 ProxyConfig.enableHttp2Connect into effective mesh ProxyConfig.
  • Enables http2_protocol_options.allow_connect on sidecar outbound HTTP listeners when effective proxy config enables it.
  • Enables the same setting on sidecar inbound HTTP service chains when effective proxy config enables it.
  • Does not configure outbound clusters.

Validation:

  • go test ./pilot/pkg/networking/core
  • go test ./pilot/pkg/model
  • go test ./pkg/model -run 'TestNodeMetadata|TestStringBool'
  • go test ./pilot/pkg/networking/core -run 'TestOutboundHTTP2ConnectProxyConfig|TestInboundHTTP2ConnectProxyConfig'
  • go test ./pilot/pkg/model -run 'TestConvertToMeshConfigProxyConfig|TestEffectiveProxyConfig'
  • git diff --check

Note: the temporary API replace should become a normal istio.io/api pseudo-version bump after the fork API PR is merged into the target API branch.

@mpuncel mpuncel force-pushed the mpuncel/websocket-grpc-coexistence branch from 1712cc8 to 15a719e Compare May 10, 2026 23:41
@mpuncel mpuncel changed the title Add inbound downstream protocol proxy metadata Support HTTP/2 extended CONNECT for WebSocket upgrades May 10, 2026
@mpuncel mpuncel force-pushed the mpuncel/websocket-grpc-coexistence branch from 15a719e to 1303aef Compare May 10, 2026 23:59
@mpuncel mpuncel changed the title Support HTTP/2 extended CONNECT for WebSocket upgrades Support HTTP/2 extended CONNECT from DestinationRule May 10, 2026
@mpuncel mpuncel force-pushed the mpuncel/websocket-grpc-coexistence branch from 1303aef to a178076 Compare May 11, 2026 10:31
@mpuncel mpuncel changed the title Support HTTP/2 extended CONNECT from DestinationRule Enable HTTP/2 extended CONNECT on sidecar listeners May 11, 2026
@mpuncel mpuncel force-pushed the mpuncel/websocket-grpc-coexistence branch from a178076 to 7722ac4 Compare May 11, 2026 12:15
@mpuncel mpuncel changed the title Enable HTTP/2 extended CONNECT on sidecar listeners Enable HTTP/2 extended CONNECT from ProxyConfig May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant