Skip to content

use public get_/ set_hatchcolor in newer mpl#161

Merged
mathause merged 4 commits intompytools:mainfrom
mathause:avoid_private_hatch_color
Aug 15, 2025
Merged

use public get_/ set_hatchcolor in newer mpl#161
mathause merged 4 commits intompytools:mainfrom
mathause:avoid_private_hatch_color

Conversation

@mathause
Copy link
Copy Markdown
Collaborator

@mathause mathause commented Aug 14, 2025

Avoids the private _hatch_color and fixes the issue exposed in #160. This is relevant to get the upstream-dev CI tests to pass. I am not sure if these changes will be in mpl 3.10.6 or in 3.11.0. I assume the latter for now but we'll see if the tests start failing again.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 95.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mplotutils/_hatch.py 98.18% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathause mathause merged commit b58c32e into mpytools:main Aug 15, 2025
9 checks passed
@mathause mathause deleted the avoid_private_hatch_color branch August 15, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️

1 participant