Skip to content

fix mpu.colorbar for matplolib v3.4 and newer#26

Merged
mathause merged 3 commits intomainfrom
fix_colorbar
Dec 23, 2022
Merged

fix mpu.colorbar for matplolib v3.4 and newer#26
mathause merged 3 commits intomainfrom
fix_colorbar

Conversation

@mathause
Copy link
Copy Markdown
Collaborator

The main difference is the usage of set_box_aspect instead of set_aspect. And also the correct computation of the position (this was simplified before and relied on mpl bbox_inches="tight" to cut them off).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 23, 2022

Codecov Report

Base: 65.50% // Head: 65.74% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (3b82d1b) compared to base (b9048b8).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   65.50%   65.74%   +0.24%     
==========================================
  Files           4        4              
  Lines         316      327      +11     
==========================================
+ Hits          207      215       +8     
- Misses        109      112       +3     
Flag Coverage Δ
min-all-deps ?
unittests 65.74% <93.10%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mplotutils/colorbar_utils.py 81.25% <93.10%> (+2.04%) ⬆️
mplotutils/__init__.py 61.53% <0.00%> (-23.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathause mathause merged commit 6cc8f8a into main Dec 23, 2022
@mathause mathause deleted the fix_colorbar branch December 23, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix compatibility of mpu.colorbar with mpl >= 3.4

2 participants