Skip to content

Conversation

@mathause
Copy link
Collaborator

@mathause mathause commented Jan 6, 2023

Fix mpu.xticklabels and mpu.yticklabels for newer versions of shapely. Add tests.

This is currently a WIP as there is still something wrong with one of the tests. I might just fix this the easy way.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Base: 82.75% // Head: 93.95% // Increases project coverage by +11.19% 🎉

Coverage data is based on head (cec04b4) compared to base (edb8e16).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
+ Coverage   82.75%   93.95%   +11.19%     
===========================================
  Files           6        6               
  Lines         319      331       +12     
===========================================
+ Hits          264      311       +47     
+ Misses         55       20       -35     
Flag Coverage Δ
min-all-deps 93.95% <60.00%> (+11.19%) ⬆️
unittests 93.95% <60.00%> (+11.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mplotutils/cartopy_utils.py 84.76% <60.00%> (+39.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathause mathause mentioned this pull request Jan 15, 2023
@mathause mathause merged commit 4248b9e into main Jan 15, 2023
@mathause mathause deleted the fix_test_xyticklabels branch January 15, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants