refactor: move to Terminal.Gui ImageView#34
Conversation
mrazza
force-pushed
the
chore/termgui-imageview
branch
from
f9a8271 to
de8f0b1
Compare
|
This PR is ready but blocked in merge of gui-cs/Terminal.Gui#5292 into the Terminal.Gui upstream repo. |
oca-agent
left a comment
oca-agent
left a comment
There was a problem hiding this comment.
Code review complete. The refactor to use Terminal.Gui's native Sixel support is a great cleanup and modernization of the codebase. Architecture is improved by decoupling the image view from the main window, and the layout adjustments for resolution-aware aspect ratios look correct. Ready for merge.
…hether or not an image is being rendered
oca-agent
left a comment
oca-agent
left a comment
There was a problem hiding this comment.
Refactor looks great. Leveraging the new ImageView simplifies the codebase significantly, and the move to asynchronous image processing is a nice performance improvement.
…yingView golden layout
oca-agent
left a comment
oca-agent
left a comment
There was a problem hiding this comment.
Re-approving PR after discussion regarding test behavior. The refactor to ImageView is correct, and the identified test flashing is a known behavior of the updated Terminal.Gui drivers that can be managed via environment variables.
2 participants
A new ImageView control in Terminal.Gui is proposed in gui-cs/Terminal.Gui#5292
This PR updates smoc to use this new control and removes a bunch of smoc-specific logic around sixel rendering.