Skip to content

Conversation

@saying121
Copy link
Contributor

@saying121 saying121 commented Mar 28, 2025

When I remove vim.lsp.handlers[vim.lsp.protocol.Methods.textDocument_hover] = vim.lsp.with(vim.lsp.handlers.hover, { border = "single" }) in neovim 0.11, hover range missing border.

I tried vim.opt.winborder = "single" but it was too noise.

I noticed that when I press KK(the K call hover range) continuously it stays in visual mod, and I need press <esc>q for exit float window so I let it automatically switch to nomal mod.

@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@saying121 saying121 changed the title In neovim 0.11 hover range missing border fix(hover_range): missing border Mar 28, 2025
@saying121 saying121 force-pushed the border branch 5 times, most recently from bd7e5ed to d56b387 Compare March 29, 2025 06:36
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Looks mostly good to me. Left a few comments.

Because this PR has both a feature and a fix, you can address my comments by:

  • fixing up the respective commits
  • or, adding a new commit with a chore: prefix (which won't get picked up by the changelog generator).

Please remove the changelog update commit.

@saying121 saying121 force-pushed the border branch 2 times, most recently from 331d208 to 243afa8 Compare March 31, 2025 10:32
@mrcjkb mrcjkb enabled auto-merge (rebase) March 31, 2025 10:47
@mrcjkb mrcjkb merged commit 8cb8aee into mrcjkb:master Mar 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants