VTKLoader: Remove usage of Geometry #14202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bunny partly uses the new code path. Unfortunately, I've found no (ASCII) VTK assets with colors. |
|
This looks good to me. Unfortunately, I cannot help with VTK test asset with colors. We are using VTP files without any color specifications in them and Paraview seems to be outputting VTK files without color scalars. |
|
@andreyyudin Thanks for your feedback. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTKLoaderalready usedBufferGeometryfor most part of the implementation. But for creating a geometry with face colors, the loader usedGeometryso far. This is now done viaBufferGeometryby converting the geometry to a non-indexed one and expanding the new color buffer data./ping @andreyyudin