Skip to content

Remove unnecessary shader chunk #14220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2018
Merged

Remove unnecessary shader chunk #14220

merged 1 commit into from
Jun 5, 2018

Conversation

WestLangley
Copy link
Collaborator

lights_pars_maps is specific to MeshStandardMaterial and MeshPhysicalMaterial only.

@WestLangley
Copy link
Collaborator Author

/ping @wizgrav webgl_tiled_forward.html is broken with this, but it appears it was broken before. Can you please have a look?

@mrdoob mrdoob added this to the r94 milestone Jun 5, 2018
@mrdoob mrdoob merged commit 98e2c56 into mrdoob:dev Jun 5, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 5, 2018

Thanks!

@WestLangley WestLangley deleted the dev-lights_pars_maps branch June 5, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r94

Development

Successfully merging this pull request may close these issues.

3 participants

@WestLangley @mrdoob @Mugen87