Skip to content

KTXLoader: Use DataView to read headers & headers should be Uint32 #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2018
Merged

KTXLoader: Use DataView to read headers & headers should be Uint32 #15417

merged 3 commits into from
Dec 13, 2018

Conversation

06wj
Copy link
Contributor

@06wj 06wj commented Dec 12, 2018 •
edited
Loading

According to the KTX specification

  • Use DataView to read header data, DataView native support for bigEndian and littleEndian data reading.
  • The header data should be Uint32.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 12, 2018

For testing: https://raw.githack.com/06wj/three.js/patch_ktx/examples/webgl_loader_texture_ktx.html

Mugen87
Mugen87 requested changes Dec 12, 2018
View reviewed changes
examples/js/loaders/KTXLoader.js Outdated
this.bytesOfKeyValueData = oppositeEndianess ? this.switchEndainness( header[ 12 ] ) : header[ 12 ]; // the amount of space after the header for meta-data
// load the reset of the header in native 32 bit uint
var dataSize = Uint32Array.BYTES_PER_ELEMENT;
var headerDataView = new DataView(this.arrayBuffer, 12, 13 * dataSize);
Copy link
Collaborator

@Mugen87 Mugen87 Dec 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code style issue. Please add a space after/before parens like so:

new DataView( this.arrayBuffer, 12, 13 * dataSize );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@mrdoob mrdoob added this to the r100 milestone Dec 13, 2018
@mrdoob mrdoob merged commit 030c805 into mrdoob:dev Dec 13, 2018
@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2018

Thanks!

@06wj 06wj deleted the patch_ktx branch December 13, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r100

Development

Successfully merging this pull request may close these issues.

3 participants

@06wj @Mugen87 @mrdoob