Skip to content

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 27, 2019

This file is not referenced in the entire repo.

@WestLangley
Copy link
Collaborator

@mrdoob added that a long time ago -- probably for its deterministic sequence.

If we want to compare screenshots someday, I expect a deterministic pseudo generator will be necessary.

There may be users who currently use this method.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 27, 2019

Okay, if @mrdoob wants to keep PRNG, I suggest to move it into the THREE namespace and the file to the math directory.

@mrdoob
Copy link
Owner

mrdoob commented May 28, 2019

We can always add it back if we need it.

@mrdoob mrdoob added this to the r105 milestone May 28, 2019
@mrdoob mrdoob merged commit e33457c into mrdoob:dev May 28, 2019
@mrdoob
Copy link
Owner

mrdoob commented May 28, 2019

Thanks!

@EliasHasle
Copy link
Contributor

I used it. ;-)

But I am fine with it being removed, as the need is easily covered by alternatives found elsewhere, or by a custom implementation. It is not as if PRNG.js was some ingenious new PRNG algorithm. It was very simple and standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants