Skip to content

Logarithmic Depth Buffer: improve test for detecting perspective matrix in fragment shader #17631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2019
Merged

Logarithmic Depth Buffer: improve test for detecting perspective matrix in fragment shader #17631

merged 2 commits into from
Oct 4, 2019

Conversation

gkjohnson
Copy link
Collaborator

Fix #17623

@gkjohnson gkjohnson mentioned this pull request Oct 1, 2019
Closed
14 tasks
@WestLangley
Copy link
Collaborator

Please see continued discussion in #17623 (comment).

@mrdoob mrdoob added this to the r110 milestone Oct 2, 2019
@mrdoob
Copy link
Owner

mrdoob commented Oct 2, 2019

I'll wait until you guys decide 👌

@WestLangley
Copy link
Collaborator

OK to merge. Thanks.

@WestLangley WestLangley changed the title Logarithmic Depth Buffer: Use loose comparison for detecting perspective matrix in fragment shader Logarithmic Depth Buffer: improve comparison for detecting perspective matrix in fragment shader Oct 4, 2019
@WestLangley WestLangley changed the title Logarithmic Depth Buffer: improve comparison for detecting perspective matrix in fragment shader Logarithmic Depth Buffer: improve test for detecting perspective matrix in fragment shader Oct 4, 2019
@Mugen87 Mugen87 merged commit 30aea40 into mrdoob:dev Oct 4, 2019
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 4, 2019

Update builds: 4c684a9

@mrdoob
Copy link
Owner

mrdoob commented Oct 4, 2019

Thanks!

@gkjohnson gkjohnson deleted the fix-logdepth-noise branch October 23, 2019 01:02
@gkjohnson gkjohnson mentioned this pull request Oct 23, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r110
Development

Successfully merging this pull request may close these issues.

Logarithmic Depth Artifacts
4 participants
@gkjohnson @WestLangley @mrdoob @Mugen87