BatchedMesh: Remove unneeded & redundant matrices array #27130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-material-properties
…erties # Conflicts: # examples/jsm/objects/BatchedMesh.js
gkjohnson
commented
Nov 6, 2023
Comment on lines
-523
to
+512
| return matrix; | ||
| return null; |
There was a problem hiding this comment.
If there is no data for the matrix then we just return null here to indicate there's no relevant value.
Mugen87
approved these changes
Nov 6, 2023
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27111, #22376
Description
Previously to toggle visibility the matrices were set to a 0 scale to "hide" them which meant that the matrices needed to be double-stored in an array and a texture so no data was lost. Now that visibility is handled by the multi-draw extension we can remove the extra
_matricesstorage.